Drop Go updatecli policy#1691
Conversation
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
There was a problem hiding this comment.
Pull request overview
Removes the Go-version Updatecli policy from the weekly dependency update compose job, and updates documentation/workflow labeling to reflect the remaining automated dependency updates.
Changes:
- Delete the unused
updatecli/updatecli.d/go.yamlpolicy and remove it from the composedupdatecli/update-deps.yaml. - Update Updatecli developer docs to no longer list Go version updates as part of the weekly workflow.
- Rename the GitHub Actions job label to reflect the remaining update targets (Rust toolchain, chart deps, Hauler manifest).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
updatecli/updatecli.d/go.yaml |
Deletes the Go Updatecli policy. |
updatecli/update-deps.yaml |
Removes the Go policy from the composed weekly dependency-update pipeline and updates the pipeline name. |
updatecli/DEVELOPING.md |
Updates the “Weekly Dependency Updates” documentation to remove Go and list remaining updates. |
.github/workflows/update-dependencies.yaml |
Updates the job display name to match the remaining dependency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
viccuad
left a comment
viccuad
left a comment
There was a problem hiding this comment.
LGTM, nowadays renovatebot bumps go.mod
|
@AkashKumar7902 can you please ensure your commit has a verified signature? Otherwise we won't be able to merge it (see the failing check) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
+ Coverage 75.53% 80.44% +4.91%
==========================================
Files 170 127 -43
Lines 20900 16413 -4487
==========================================
- Hits 15786 13203 -2583
+ Misses 4902 3210 -1692
+ Partials 212 0 -212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I checked the signature blocker here too. The current head commit is unsigned, and the local SSH key available in this environment is not registered as a GitHub signing key. I tried adding it, but the current I also handled the Copilot PR-description thread by changing |
Summary
updatecli/updatecli.d/go.yamlpolicyRefs #1639
Testing
rg -n 'go\\.yaml|Update Go version|Golang version|update Golang|golang/version|Go version ingo\.mod' updatecli .github || true\n-yq e . updatecli/update-deps.yaml >/dev/null\n-yq e . .github/workflows/update-dependencies.yaml >/dev/null\n-git diff --check\n\nupdatecliandactionlintare not installed in my local environment.